Add SRI integrity hashes and crossorigin to CDN resources#100
Add SRI integrity hashes and crossorigin to CDN resources#100xihale merged 1 commit intozigcc:mainfrom
Conversation
Summary of ChangesHello @xihale, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the security posture of the application by implementing Subresource Integrity (SRI) and appropriate Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enhances security by adding Subresource Integrity (SRI) hashes and crossorigin attributes to all CDN-hosted resources. This is an excellent security practice that helps prevent attacks from a compromised CDN. The changes are correct and well-implemented. I've added a few minor suggestions to improve code readability by formatting some of the long lines.
上游已经修复了 Access-Control-Allow-Origin 缺失的相关问题,可以加入 integrity 验证确保资源安全。