Skip to content

Remove undefined reference to rmprocs#101

Merged
giordano merged 1 commit intomainfrom
mg/rm-rmprocs
Mar 1, 2026
Merged

Remove undefined reference to rmprocs#101
giordano merged 1 commit intomainfrom
mg/rm-rmprocs

Conversation

@giordano
Copy link
Collaborator

@giordano giordano commented Mar 1, 2026

I believe this was missed in #48, and since this is under @async the error went into the void. Not sure whether it should be replaced by something else, I think all the workers should already be terminated elsewhere, right?

Undefined reference detected by JETLS.

@giordano giordano requested review from maleadt and vchuravy March 1, 2026 14:23
@giordano
Copy link
Collaborator Author

giordano commented Mar 1, 2026

Mumble mumble mumble...if I run

julia> using ParallelTestRunner

julia> testsuite = Dict(
           "a" => :(),
           "b" => :(),
           "c" => :(),
           "d" => :(),
       );

julia> runtests(ParallelTestRunner, ["--jobs=4"]; testsuite);
Running 4 tests in parallel. If this is too many, specify the `--jobs=N` argument to the tests, or set the `JULIA_CPU_THREADS` environment variable.
               │          │ ──────────────── CPU ──────────────── │
Test  (Worker) │ Time (s) │ GC (s) │ GC % │ Alloc (MB) │ RSS (MB) │
b          (1) │     0.05 │   0.00 │  0.0 │       4.81 │   325.02 │
d          (2) │     0.05 │   0.00 │  0.0 │       4.81 │   324.19 │
a          (4) │     0.05 │   0.00 │  0.0 │       4.81 │   324.64 │
c          (3) │     0.05 │   0.00 │  0.0 │       4.81 │   323.78 │

Test Summary: | Total  Time
  Overall     |     0  4.1s
    SUCCESS

and then look at the output of

ps -ax | grep julia

I see all the four workers still alive. Doesn't look like they're actually stopped when they finish?

@giordano giordano force-pushed the mg/rm-rmprocs branch 2 times, most recently from 950135f to 1c01c62 Compare March 1, 2026 14:57
@giordano giordano force-pushed the mg/rm-rmprocs branch 2 times, most recently from 311f174 to a5b06d5 Compare March 1, 2026 15:06
@giordano
Copy link
Collaborator Author

giordano commented Mar 1, 2026

I'm going to merge this PR because it fixes a (small) bug, but I opened an issue about the workers not being stopped at the end: #106.

@giordano giordano merged commit 33980bb into main Mar 1, 2026
23 checks passed
@giordano giordano deleted the mg/rm-rmprocs branch March 1, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant