Skip to content

Remove useless workers variable#103

Merged
giordano merged 1 commit intomainfrom
mg/rm-workers
Mar 1, 2026
Merged

Remove useless workers variable#103
giordano merged 1 commit intomainfrom
mg/rm-workers

Conversation

@giordano
Copy link
Collaborator

@giordano giordano commented Mar 1, 2026

Taken out of #101. Ref: #101 (comment).

This was referenced Mar 1, 2026
Merged
Merged
@giordano giordano merged commit 7f27702 into main Mar 1, 2026
23 checks passed
@giordano giordano deleted the mg/rm-workers branch March 1, 2026 15:41
@christiangnrd
Copy link
Contributor

christiangnrd commented Mar 1, 2026

Unless it's there for code clarity, I think nworkers can also be removed and replaced with jobs since jobs is already clamped to a max of length(tests).

@giordano
Copy link
Collaborator Author

giordano commented Mar 1, 2026

I think this PR was correct after #100, but #100 actually broke reusing workers: #100 (comment), so they should both be reverted, or just fix everything. I'll try to look into it in a bit.

giordano added a commit that referenced this pull request Mar 1, 2026
@giordano
Revert "Remove useless workers variable (#103)"
5488684 
This reverts commit 7f27702.
giordano added a commit that referenced this pull request Mar 1, 2026
@giordano
Revert changes which broke reuse of workers (#105)
c8a7836 
* Revert "Remove useless `workers` variable (#103)"

This reverts commit 7f27702.

* Revert "Slightly improve inferred types in `runtests` (#100)"

This reverts commit 16f47d4.

* Add a test to ensure workers are reused correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@giordano @christiangnrd