[NFC] Use a bitset instead of bools in effects.h#8402
Open
Conversation
EffectAnalyzer tracks many effects that are just bools. Update it to use bits in a uint32_t instead. This not only makes EffectAnalyzer smaller now, but also allows us to add more effects in the future without making it larger. This change does not appear to have a meaningful effect on the performance of -O3 on large Wasm GC binaries, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EffectAnalyzer tracks many effects that are just bools. Update it to use
bits in a uint32_t instead. This not only makes EffectAnalyzer smaller
now, but also allows us to add more effects in the future without making
it larger. This change does not appear to have a meaningful effect on
the performance of -O3 on large Wasm GC binaries, though.