refactor: centralize ESLint file targeting within eslint.config.mjs to process only TypeScript files and ignore JavaScript files#32601
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Feb 26, 2026
Conversation
… to process only TypeScript files and ignore JavaScript files This is needed as the glob is no longer being parsed from the CLI. ``` Run pnpm lint --cache-strategy content > @angular/devkit-repo@22.0.0-next.0 lint /home/runner/work/angular-cli/angular-cli > eslint --cache --max-warnings=0 "**/*.@(ts|mts|cts)" --cache-strategy content Oops! Something went wrong! :( ESLint: 10.0.2 No files matching the pattern "**/*.@(ts|mts|cts)" were found. Please check for typing mistakes in the pattern. ELIFECYCLE Command failed with exit code 2. ```
clydin
reviewed
Feb 26, 2026
Comment on lines
+31
to
+33
| '**/*.js', | ||
| '**/*.mjs', | ||
| '**/*.cjs', |
Member
There was a problem hiding this comment.
do we need both this and the above?
Collaborator
Author
There was a problem hiding this comment.
You mean the cjs variant?
Member
There was a problem hiding this comment.
i meant the ignore plus the files options
Collaborator
Author
There was a problem hiding this comment.
Yes it was not working correctly when it was in the same object.
clydin
approved these changes
Feb 26, 2026
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed as the glob is no longer being parsed from the CLI.