Skip to content

refactor: centralize ESLint file targeting within eslint.config.mjs to process only TypeScript files and ignore JavaScript files #32601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Feb 26, 2026
Merged

refactor: centralize ESLint file targeting within eslint.config.mjs to process only TypeScript files and ignore JavaScript files #32601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ import { fixupConfigRules, fixupPluginRules } from '@eslint/compat';
import { FlatCompat } from '@eslint/eslintrc';
import js from '@eslint/js';
import stylistic from '@stylistic/eslint-plugin';
import header from '@tony.ganchev/eslint-plugin-header';
import typescriptEslint from '@typescript-eslint/eslint-plugin';
import tsParser from '@typescript-eslint/parser';
import header from '@tony.ganchev/eslint-plugin-header';
import _import from 'eslint-plugin-import';
import globals from 'globals';

Expand All @@ -23,8 +23,14 @@ const compat = new FlatCompat({
});

export default [
{
files: ['**/*.ts', '**/*.mts', '**/*.cts'],
},
{
ignores: [
'**/*.js',
'**/*.mjs',
'**/*.cjs',
Comment on lines +31 to +33
Copy link
Member

@clydin clydin Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need both this and the above?

Copy link
Collaborator Author

@alan-agius4 alan-agius4 Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the cjs variant?

Copy link
Member

@clydin clydin Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i meant the ignore plus the files options

Copy link
Collaborator Author

@alan-agius4 alan-agius4 Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it was not working correctly when it was in the same object.

'**/bazel-out',
'**/dist-schema',
'goldens/public-api',
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"test": "bazel test //packages/...",
"build": "pnpm -s admin build",
"build-schema": "bazel build //... --build_tag_filters schema --symlink_prefix dist-schema/",
"lint": "eslint --cache --max-warnings=0 \"**/*.@(ts|mts|cts)\"",
"lint": "eslint --cache --max-warnings=0",
"templates": "pnpm -s admin templates",
"validate": "pnpm -s admin validate",
"postinstall": "husky",
Expand Down
Loading