fix: missing runtime and duplicate dependencies#250
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a regression that caused missing runtime dependencies and duplicate dependencies for JUnit and testing. The fix involves two main changes: removing the scope-based filtering when parsing Maven POM dependencies (which was preventing runtime-scoped dependencies from being included), and adding stricter configuration filtering to exclude test-related, annotation processor, and other non-production configurations when discovering dependencies from Gradle projects.
Changes:
- Removed the compile-only scope filter from Maven POM dependency parsing to include runtime dependencies
- Added explicit exclusion of test, annotation processor, kapt, lint, and detached configurations when discovering dependencies from Gradle
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...react/brownfield/src/main/kotlin/com/callstack/react/brownfield/expo/ExpoPublishingHelper.kt
Show resolved
Hide resolved
...react/brownfield/src/main/kotlin/com/callstack/react/brownfield/expo/ExpoPublishingHelper.kt
Outdated
Show resolved
Hide resolved
...react/brownfield/src/main/kotlin/com/callstack/react/brownfield/expo/ExpoPublishingHelper.kt
Outdated
Show resolved
Hide resolved
…react/brownfield/expo/ExpoPublishingHelper.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a recent regression by which we have missing runtime and duplicate dependencies for junit and testing. We fix this by reverting the change for runtime dependencies and opting for simpler configurations.
Test plan
CI Passes - 🟢
Verified Locally 👍