Skip to content

fix: missing runtime and duplicate dependencies #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hurali97 merged 4 commits into from
Feb 24, 2026
Merged

fix: missing runtime and duplicate dependencies #250

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf71eaf
fix: missing runtime and duplicate dependencies
hurali97 Feb 24, 2026
a4dad19
Update gradle-plugins/react/brownfield/src/main/kotlin/com/callstack/…
hurali97 Feb 24, 2026
ac13155
refactor: make the impl simpler
hurali97 Feb 24, 2026
e728572
docs: add comments
hurali97 Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions ...ct/brownfield/src/main/kotlin/com/callstack/react/brownfield/expo/ExpoPublishingHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,18 +353,15 @@ open class ExpoPublishingHelper(val brownfieldAppProject: Project) {
depNodeList.childNodes.forEach { depNode ->
/**
* below: some nodes are not dependencies, but pure text, in which case their name is '#text'
*
* Only add dependencies with compile scope, if scope is null, default to compile
*/
val scope = depNode.getChildNodeByName("scope")?.textContent
if (depNode.nodeName == "dependency" && (scope == null || scope == "compile")) {
if (depNode.nodeName == "dependency") {
val groupId = depNode.getChildNodeByName("groupId")!!.textContent
val maybeArtifactId = depNode.getChildNodeByName("artifactId")

val artifactId = maybeArtifactId!!.textContent
val version = depNode.getChildNodeByName("version")?.textContent
val optional = depNode.getChildNodeByName("optional")?.textContent

val scope = depNode.getChildNodeByName("scope")?.textContent
val dependencyInfo =
DependencyInfo(
groupId = groupId,
Expand All @@ -384,11 +381,13 @@ open class ExpoPublishingHelper(val brownfieldAppProject: Project) {
pkgProject: Project,
dependencies: VersionMediatingDependencySet,
) {
val configurations = pkgProject.configurations.matching {
it.name.contains("implementation", ignoreCase = true) || it.name.contains("api", ignoreCase = true)
}
configurations.forEach {
it.dependencies.forEach { dep ->
/**
* Not accounting for variant specific configurations as Expo packages are not
* using it. Should we face any issues/needs to account for it, we can do it here.
*/
listOf("implementation", "api", "runtime").forEach {
val configuration = pkgProject.configurations.findByName(it)
configuration?.dependencies?.forEach { dep ->
if (dep.group != null) {
dependencies.add(
DependencyInfo.fromGradleDep(
Expand Down