Conversation
…#26056) No user-facing change included in this commit - this just deletes dead code. These hooks were used when analytics was gated behind a feature flag, but they're currently not in use anywhere in the stats app. It's a little confusing to keep these around, especially because the naming isn't as specific as it could be. We can always reintroduce these if we need to gate certain routes by feature flag, with a more specific name.
ref https://github.com/TryGhost/Ghost/actions/runs/22154549172/job/64055168837 We had an assertion error like this: Email HTML should not contain OTC. Found: "860572" near: "0.1:4015/members/?token=th0fWUDq5WKKteGjd3CSaLYwIC860572&action=signin" If the token has six consecutive numbers, the test will fail. To fix that, we only check the actual text, not HTML attributes.
no ref This is a test-only change that should have no user impact. Now that we're not using Should.js any more, we can remove it completely.
…26501) refs https://github.com/TryGhost/Ghost/actions/runs/22159115008/job/64071040152 Portal donations tests were flaking fairly frequently in CI. The `submitStripePayment` flow in e2e-browser-utils was clicking on the submit button in Stripe Checkout and then exiting. This prematurely started subsequent assertions in the tests, before the redirect back to Ghost had completed. This fixes that by waiting for the url to no longer include stripe.checkout.com, indicating that the redirect back to Ghost has completed, and only then starting the assertions in the tests themselves. This fix was in response to flaky donations tests, but it should also improve the reliability of any test that uses Stripe checkout: - ghost/core/test/e2e-browser/portal/donations.spec.js - ghost/core/test/e2e-browser/portal/tiers.spec.js - ghost/core/test/e2e-browser/portal/upgrade.spec.js - ghost/core/test/e2e-browser/portal/offers.spec.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )