[pull] main from TryGhost:main

apps/stats/src/routes.tsx

@@ -1,12 +1,7 @@
 import {RouteObject, lazyComponent} from '@tryghost/admin-x-framework';
-// import {withFeatureFlag} from './hooks/withFeatureFlag';
 
 export const APP_ROUTE_PREFIX = '/';
 
-// Wrap all components with feature flag protection
-//  e.g.
-// const ProtectedOverview = withFeatureFlag(Overview, 'trafficAnalyticsAlpha', '/', 'Overview');
-
 export const routes: RouteObject[] = [
     {
         path: 'analytics',

ghost/core/package.json

@@ -257,7 +257,6 @@
     "postcss": "8.5.6",
     "postcss-cli": "11.0.1",
     "rewire": "8.0.0",
-    "should": "13.2.3",
     "sinon": "18.0.1",
     "supertest": "6.3.4",
     "tmp": "0.2.5",

ghost/core/test/e2e-api/admin/actions.test.js

@@ -1,5 +1,4 @@
 const assert = require('node:assert/strict');
-const should = require('should');
 const sinon = require('sinon');
 const supertest = require('supertest');
 const testUtils = require('../../utils');

ghost/core/test/e2e-api/admin/comments.test.js

@@ -1,5 +1,4 @@
 const assert = require('node:assert/strict');
-require('should');
 const ObjectId = require('bson-objectid').default;
 const {
     agentProvider,

ghost/core/test/e2e-api/admin/files.test.js

@@ -1,7 +1,6 @@
 const assert = require('node:assert/strict');
 const path = require('path');
 const fs = require('fs-extra');
-const should = require('should');
 const supertest = require('supertest');
 const localUtils = require('./utils');
 const config = require('../../../core/shared/config');

ghost/core/test/e2e-api/admin/integrations.test.js

@@ -1,7 +1,6 @@
 const assert = require('node:assert/strict');
 const {assertExists} = require('../../utils/assertions');
 const _ = require('lodash');
-const should = require('should');
 const supertest = require('supertest');
 const config = require('../../../core/shared/config');
 const testUtils = require('../../utils');

ghost/core/test/e2e-api/admin/invites.test.js

@@ -1,6 +1,5 @@
 const assert = require('node:assert/strict');
 const {assertExists} = require('../../utils/assertions');
-const should = require('should');
 const supertest = require('supertest');
 const sinon = require('sinon');
 const testUtils = require('../../utils');

ghost/core/test/e2e-api/admin/key-authentication.test.js

@@ -1,6 +1,5 @@
 const assert = require('node:assert/strict');
 const {assertExists} = require('../../utils/assertions');
-const should = require('should');
 const supertest = require('supertest');
 const testUtils = require('../../utils');
 const config = require('../../../core/shared/config');

ghost/core/test/e2e-api/admin/max-limit-cap.test.js

@@ -1,6 +1,5 @@
 const assert = require('node:assert/strict');
 const {agentProvider, fixtureManager} = require('../../utils/e2e-framework');
-const should = require('should');
 const sinon = require('sinon');
 const db = require('../../../core/server/data/db');
 const ObjectId = require('bson-objectid').default;