feat: add .call() pattern support to JS test instrumentation#1523
Open
mohammedahmed18 wants to merge 5 commits intomainfrom
Open
feat: add .call() pattern support to JS test instrumentation#1523mohammedahmed18 wants to merge 5 commits intomainfrom
mohammedahmed18 wants to merge 5 commits intomainfrom
Conversation
Instrument funcName.call(thisArg, args) patterns in both standalone and expect-wrapped contexts, transforming them to codeflash.capture() with func.bind(thisArg). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
PR Review SummaryPrek Checks✅ All checks pass — ruff check and ruff format both passed with no issues. Mypy✅ No new mypy issues introduced by this PR. Pre-existing issues only:
Code Review✅ No critical issues found. Changes reviewed:
Test Coverage
Codeflash Optimization PRs
Last updated: 2026-02-18T14:30 UTC |
Contributor
⚡️ Codeflash found optimizations for this PR📄 147% (1.47x) speedup for
|
The optimized code achieves a **172% speedup** (85.2ms → 31.3ms) by eliminating a critical O(n²) performance bottleneck in the `transform()` method. ## Key Optimization **Problem**: The original code called `is_inside_string(code, match.start())` for every regex match found. This function scans from position 0 to the match position each time, resulting in O(n²) complexity when processing code with many matches. **Solution**: The optimization replaces these repeated scans with **incremental string state tracking** directly in the main loop. Instead of rescanning from the beginning for each match, the code maintains `in_string`, `string_char`, and `last_checked_pos` variables that preserve state between iterations. When a new match is found, only the code between `last_checked_pos` and `match_start` is scanned to update the string state. ## Performance Impact The line profiler data clearly shows the improvement: - **Original**: `is_inside_string()` consumed 0.618s (95.2% of transform time) with 432 calls scanning 887,510 characters total - **Optimized**: The inline tracking logic in transform() consumes only 0.021s (33% of transform time) by scanning just 28,273 characters incrementally Test results demonstrate strong gains on workloads with many matches: - `test_transform_many_invocations`: 12.3ms → 4.84ms (155% faster) - `test_transform_large_code_file`: 40.6ms → 14.0ms (191% faster) - `test_transform_alternating_patterns`: 2.64ms → 519μs (408% faster) - `test_transform_mixed_qualified_names`: 14.0ms → 5.14ms (173% faster) The optimization particularly benefits code with frequent expect() calls, as each avoided `is_inside_string()` call saves scanning hundreds or thousands of characters. This makes the transformer significantly faster on realistic test files with multiple assertions.
Contributor
⚡️ Codeflash found optimizations for this PR📄 173% (1.73x) speedup for
|
…2026-02-18T13.29.34 ⚡️ Speed up method `ExpectCallTransformer.transform` by 173% in PR #1523 (`feat/js-dot-call-instrumentation`)
Contributor
|
This PR is now faster! 🚀 @mohammedahmed18 accepted my optimizations from: |
Contributor
⚡️ Codeflash found optimizations for this PR📄 15,016% (150.16x) speedup for
|
Contributor
⚡️ Codeflash found optimizations for this PR📄 772% (7.72x) speedup for
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.call()pattern (funcName.call(thisArg, args)) in JavaScript test code.call()invocations tocodeflash.capture('name', 'id', func.bind(thisArg), args)in both standalone and expect-wrapped contextssplit_call_args()helper to correctly parse.call()arguments handling nested parens, brackets, braces, and string literalsTest plan
IdempotencyInterceptor.prototype.getIdempotencyKey.call()pattern🤖 Generated with Claude Code