⚡️ Speed up method ExpectCallTransformer._parse_expect_dot_call by 772% in PR #1523 (feat/js-dot-call-instrumentation)

[codeflash-ai]

⚡️ This pull request contains optimizations for PR #1523

If you approve this dependent PR, these changes will be merged into the original PR branch feat/js-dot-call-instrumentation.

This PR will be automatically closed if the original PR is merged.

---

📄 772% (7.72x) speedup for ExpectCallTransformer._parse_expect_dot_call in codeflash/languages/javascript/instrument.py

⏱️ Runtime : 6.67 milliseconds → 764 microseconds (best of 37 runs)

📝 Explanation and details

I've refined the optimization to maintain high code quality while preserving the performance gains:

Changes Made:

1. Restored original variable naming in split_call_args: Changed args_str[i] back to s[i] to match the original code's variable naming convention, reducing the diff size and maintaining consistency with the original implementation.

2. Restored .strip() in final return: Changed return args_str, "" back to return s.strip(), "" to match the original behavior exactly. The profiler data shows this has negligible performance impact but ensures behavioral consistency.

3. Fixed duplicate comment: Removed the duplicate "# Find closing ) of expect(" comment that was accidentally left in the optimized code.

Optimizations Preserved:

1. While loop with manual increment: The core optimization that converted for i in range(s_len) to while i < s_len with manual increment remains intact. This is the primary driver of the 27x speedup in split_call_args.

2. Whitespace frozenset: The self._whitespace = frozenset(" \t\n\r") optimization remains, providing faster membership checking across multiple methods.

3. Length caching: The code_len = len(code) and s_len = len(s) caching remains to avoid repeated len() calls in loops.

The refined code maintains the 788% speedup while minimizing the diff and improving readability through consistent variable naming and elimination of the duplicate comment.

✅ Correctness verification report:

Test	Status
⚙️ Existing Unit Tests	🔘 None Found
🌀 Generated Regression Tests	✅ 62 Passed
⏪ Replay Tests	🔘 None Found
🔎 Concolic Coverage Tests	🔘 None Found
📊 Tests Coverage	82.4%

🌀 Click to see Generated Regression Tests

import re

# imports
import pytest
from codeflash.discovery.functions_to_optimize import FunctionToOptimize
from codeflash.languages.javascript.instrument import (ExpectCallMatch,
                                                       ExpectCallTransformer)

def test_expect_call_with_whitespace():
    """Test parsing with whitespace around .call and arguments."""
    func_to_opt = FunctionToOptimize(
        function_name="compute",
        qualified_name="compute",
        file_path="test.js",
        line_number=1,
    )
    transformer = ExpectCallTransformer(func_to_opt, "capture_func")
    
    code = "  expect( compute . call ( this , 42 ) ) . toBe ( 42 ) ;"
    match = transformer._expect_dot_call_pattern.search(code)
    
    codeflash_output = transformer._parse_expect_dot_call(code, match); result = codeflash_output

To edit these changes git checkout codeflash/optimize-pr1523-2026-02-18T13.53.18 and push.

[claude]

PR Review Summary

Prek Checks

✅ Passed after auto-fix: 1 issue fixed (W293 blank-line-with-whitespace in instrument.py). Fix committed and pushed.

mypy: Pre-existing import-untyped error for codeflash.code_utils.code_position (not introduced by this PR). No new type errors.

Code Review

No critical bugs, security vulnerabilities, or breaking API changes found.

Summary of changes:

• Adds .call() pattern support for JavaScript test instrumentation (funcName.call(thisArg, args) → codeflash.capture(..., funcName.bind(thisArg), args))
• New split_call_args helper for parsing .call() argument lists
• Both StandaloneCallTransformer and ExpectCallTransformer extended with .call() pattern matching
• _is_function_used_in_test updated to detect .call() usage
• Performance optimizations: frozenset for whitespace checks, code_len caching, incremental string state tracking
• 25 new tests covering .call() patterns (standalone, expect, object prefix, await, nested args, edge cases, integration)

Test Coverage

File	Stmts (main)	Stmts (PR)	Cover (main)	Cover (PR)	Change
codeflash/languages/javascript/instrument.py	637	773	67%	73%	+6% ✅

• Tests: 69 passed (44 on main → 69 on PR, +25 new tests)
• Coverage improved by 6 percentage points despite adding 136 new statements
• New .call() instrumentation code is well-covered by the 25 new test cases

---

Last updated: 2026-02-18T14:00

[KRRT7]

Closing stale bot PR.