Fix null Event ID in adk_request_confirmation events

[YuqiGuo105]

Fixes #871

Events generated for tool confirmation requests (adk_request_confirmation) were being created with null IDs because the generateRequestConfirmationEvent() method was missing the .id(Event.generateEventId()) call in the Event builder.

This commit:

• Adds .id(Event.generateEventId()) to generateRequestConfirmationEvent() in Functions.java to ensure all confirmation request events have non-null UUIDs
• Adds regression test generateRequestConfirmationEvent_generatesNonNullEventId() to FunctionsTest.java to verify the fix

[gemini-code-assist]

Summary of Changes

Hello @YuqiGuo105, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug where event IDs for tool confirmation requests were not being generated, leading to null IDs. The fix involves explicitly adding ID generation to the event builder for these specific events. Additionally, a new regression test has been introduced to ensure the correct behavior and prevent the reintroduction of this bug.

Highlights

• Bug Fix: Resolved an issue where adk_request_confirmation events were being created with null Event IDs.
• Event ID Generation: Ensured that all confirmation request events generated by generateRequestConfirmationEvent() now include a unique, non-null ID.
• Regression Test: Added a new test case, generateRequestConfirmationEvent_generatesNonNullEventId(), to prevent future regressions of this issue.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• core/src/main/java/com/google/adk/flows/llmflows/Functions.java
  • Added .id(Event.generateEventId()) to the Event.builder() within the generateRequestConfirmationEvent method to ensure all generated events have a unique ID.
• core/src/test/java/com/google/adk/flows/llmflows/FunctionsTest.java
  • Imported EventActions, ToolConfirmation, and ConcurrentHashMap to support the new test case.
  • Added a new test method generateRequestConfirmationEvent_generatesNonNullEventId() to verify that events generated by generateRequestConfirmationEvent have non-null and non-empty IDs.

Activity

• No specific activity has been recorded for this pull request yet, beyond its creation and the initial commit.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively resolves a bug where adk_request_confirmation events were generated with null IDs. The fix, which involves adding .id(Event.generateEventId()) in Functions.java, is correct and directly addresses the issue. The inclusion of a new regression test in FunctionsTest.java is a great addition, ensuring this issue does not reoccur. The changes are well-implemented and adhere to the project's coding standards. The pull request is ready for merging.