Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -686,6 +686,7 @@ public static Optional<Event> generateRequestConfirmationEvent(

return Optional.of(
Event.builder()
.id(Event.generateEventId())
.invocationId(invocationContext.invocationId())
.author(invocationContext.agent().name())
.branch(invocationContext.branch())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
import com.google.adk.agents.RunConfig;
import com.google.adk.agents.RunConfig.ToolExecutionMode;
import com.google.adk.events.Event;
import com.google.adk.events.EventActions;
import com.google.adk.events.ToolConfirmation;
import com.google.adk.testing.TestUtils;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
Expand All @@ -34,6 +36,7 @@
import com.google.genai.types.FunctionResponse;
import com.google.genai.types.Part;
import java.util.Optional;
import java.util.concurrent.ConcurrentHashMap;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
Expand Down Expand Up @@ -395,4 +398,52 @@ public void getAskUserConfirmationFunctionCalls_eventWithConfirmationFunctionCal
ImmutableList<FunctionCall> result = Functions.getAskUserConfirmationFunctionCalls(event);
assertThat(result).containsExactly(confirmationCall1, confirmationCall2);
}

@Test
public void generateRequestConfirmationEvent_generatesNonNullEventId() {
InvocationContext invocationContext = createInvocationContext(createRootAgent());
String functionCallId = "function_call_123";

// Create a function call event with a function call that has an ID
Event functionCallEvent =
Event.builder()
.id("event1")
.invocationId(invocationContext.invocationId())
.author(invocationContext.agent().name())
.content(
Content.fromParts(
Part.builder()
.functionCall(
FunctionCall.builder()
.id(functionCallId)
.name("some_tool")
.args(ImmutableMap.of())
.build())
.build()))
.build();

// Create a function response event with requestedToolConfirmations
ConcurrentHashMap<String, ToolConfirmation> toolConfirmations = new ConcurrentHashMap<>();
toolConfirmations.put(functionCallId, ToolConfirmation.builder().build());

EventActions actionsWithConfirmation =
EventActions.builder().requestedToolConfirmations(toolConfirmations).build();

Event functionResponseEvent =
Event.builder()
.id("event2")
.invocationId(invocationContext.invocationId())
.author(invocationContext.agent().name())
.content(Content.fromParts(Part.fromText("response")))
.actions(actionsWithConfirmation)
.build();

Optional<Event> result =
Functions.generateRequestConfirmationEvent(
invocationContext, functionCallEvent, functionResponseEvent);

assertThat(result).isPresent();
assertThat(result.get().id()).isNotNull();
assertThat(result.get().id()).isNotEmpty();
}
}