refactor: extract AnophelesIhsAnalysis and add simulated-data tests#1004
Open
ritoban23 wants to merge 1 commit intomalariagen:masterfrom
Open
refactor: extract AnophelesIhsAnalysis and add simulated-data tests#1004ritoban23 wants to merge 1 commit intomalariagen:masterfrom
ritoban23 wants to merge 1 commit intomalariagen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the ongoing Anopheles God-class refactor (#366).
What this PR does
Extracts all iHS (integrated haplotype score) analysis methods from
AnophelesDataResourceinanopheles.pyinto a new dedicated mixin classAnophelesIhsAnalysis, following the same pattern already used byAnophelesH12Analysis,AnophelesG123Analysis, etc.Files changed
malariagen_data/anoph/ihs.py(new) —AnophelesIhsAnalysis(AnophelesHapData)mixin containingihs_gwss,_ihs_gwss,plot_ihs_gwss_track, andplot_ihs_gwssmalariagen_data/anopheles.py— removed the four iHS methods and abstract cache-name property; addedAnophelesIhsAnalysisimport and inserted it into the MROtests/anoph/test_ihs.py(new) — 7 test functions × 2 simulated-data fixtures (ag3, af1) = 14 parametrised tests covering basic runs, caching, windowing, sample queries, and percentile shapesTesting