fix: resolve KeyError and fragile array slicing in haplotypes_frequencies_advanced()`#982
Open
blankirigaya wants to merge 2 commits intomalariagen:masterfrom
Open
fix: resolve KeyError and fragile array slicing in haplotypes_frequencies_advanced()`#982blankirigaya wants to merge 2 commits intomalariagen:masterfrom
blankirigaya wants to merge 2 commits intomalariagen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
KeyError: 'label'that makeshaplotypes_frequencies_advanced()completely unusable, and replaces fragile positional
.to_numpy()slicingwith explicit named column selection.
Closes #<ISSUE_NUMBER>
Changes
In
malariagen_data/anoph/hap_frq.py:set_index("label")call that was dropping thelabelcolumn before it could be readdf.to_numpy()[:, :n]positional slices withdf[freq_cols].to_numpy()etc. using explicit column name listsset_indexentirely (return value isds_out, notdf_haps_sorted)Files Changed
malariagen_data/anoph/hap_frq.py