.github/workflows: Migrate workflows to Blacksmith runners#39
.github/workflows: Migrate workflows to Blacksmith runners#39markovejnovic merged 1 commit intomainfrom
Conversation
Mesa DescriptionTo whomever may be reviewing this PR, Blacksmith is the fastest way to run your GitHub Actions. What does this PR change?This PR has been automatically generated by a team member in your GitHub organization using Blacksmith's Migration Wizard, or MigWiz for short. This PR changes the following:
FAQ
Description generated by Mesa. Update settings |
There was a problem hiding this comment.
Performed full review of 809e26f...2f14aad
Analysis
- Moving to self-hosted runners prevents CI jobs from running on public forks, impacting contributor workflow
- Trust boundaries for sensitive operations (e.g., release publishing) shift to Blacksmith infrastructure
- No fallback mechanism to GitHub-hosted runners if self-hosted infrastructure fails
- Missing documentation for contributors about new self-hosted runner requirements
Tip
Help
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
3 files reviewed | 1 comments | Edit Agent Settings • Read Docs
| lint: | ||
| name: Ruff & Pyright | ||
| runs-on: ubuntu-latest | ||
| runs-on: blacksmith-2vcpu-ubuntu-2404 |
There was a problem hiding this comment.
Switching this job to a private blacksmith-* runner removes the ability for forked pull requests to run the lint workflow. GitHub does not allow public forks to target self-hosted runners, so external contributions will now queue forever or be skipped, which means we lose CI signal before merging. Could we keep ubuntu-latest (or provide a GitHub-hosted fallback via a matrix) so community PRs still get lint coverage?
Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: mesa-dot-dev/gitfs#39
File: .github/workflows/python-lint.yml#L16
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.
Feedback:
Switching this job to a private `blacksmith-*` runner removes the ability for forked pull requests to run the lint workflow. GitHub does not allow public forks to target self-hosted runners, so external contributions will now queue forever or be skipped, which means we lose CI signal before merging. Could we keep `ubuntu-latest` (or provide a GitHub-hosted fallback via a matrix) so community PRs still get lint coverage?
To whomever may be reviewing this PR,
Blacksmith is the fastest way to run your GitHub Actions.
What does this PR change?
This PR has been automatically generated by a team member in your GitHub organization using Blacksmith's Migration Wizard, or MigWiz for short. This PR changes the following:
runs-on: blacksmith-4vcpu-ubuntu-2204). Learn more about the different instances available to choose from.FAQ