Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/python-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ concurrency:
jobs:
lint:
name: Ruff & Pyright
runs-on: ubuntu-latest
runs-on: blacksmith-2vcpu-ubuntu-2404
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium

Switching this job to a private blacksmith-* runner removes the ability for forked pull requests to run the lint workflow. GitHub does not allow public forks to target self-hosted runners, so external contributions will now queue forever or be skipped, which means we lose CI signal before merging. Could we keep ubuntu-latest (or provide a GitHub-hosted fallback via a matrix) so community PRs still get lint coverage?

Fix in Cursor • Fix in Claude

Prompt for Agent
Task: Address review feedback left on GitHub.
Repository: mesa-dot-dev/gitfs#39
File: .github/workflows/python-lint.yml#L16
Action: Open this file location in your editor, inspect the highlighted code, and resolve the issue described below.

Feedback:
Switching this job to a private `blacksmith-*` runner removes the ability for forked pull requests to run the lint workflow. GitHub does not allow public forks to target self-hosted runners, so external contributions will now queue forever or be skipped, which means we lose CI signal before merging. Could we keep `ubuntu-latest` (or provide a GitHub-hosted fallback via a matrix) so community PRs still get lint coverage?

timeout-minutes: 10

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ jobs:
release:
name: Create GitHub Release
needs: [version, linux-deb, linux-rpm, linux-tarball, macos-universal]
runs-on: ubuntu-latest
runs-on: blacksmith-2vcpu-ubuntu-2404
steps:
- uses: actions/checkout@v4

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/shellcheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ concurrency:
jobs:
shellcheck:
name: ShellCheck
runs-on: ubuntu-latest
runs-on: blacksmith-2vcpu-ubuntu-2404
steps:
- uses: actions/checkout@v4

Expand Down