MCP SDK: Add Prettier to Typescript SDK#953
MCP SDK: Add Prettier to Typescript SDK#953KKonstantinov wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
|
PS. If maintainers prefer, I could commit just the prettier config, and a maintainer could then run the initial prettier command to avoid having to review all changes generated by prettier. |
0845a57 to
c94ba4b
Compare
@KKonstantinov yes please 🙏 Just to avoid merge conflicts, planning to merge some PRs this week and then can merge this PR, run prettier and just push. |
|
Closing in favour of #976, which contains prettier config only. |
|
@KKonstantinov @ihrpr I think this should be the one we merge. We have to get through this - adding prettier and formatting the whole repo - once. It might as well be in this PR. |
This PR's aim is to introduce Prettier to the Typescript SDK, in order to have consistent formatting.
Motivation and Context
Formatting is not automatic and there is no code formatting/styling tool to standardize that. That leads to PR code reviews having to manually identify any styling issues as opposed to that being automatic.
It is integrating prettier with the existing ESlint set up, and adding prettier --check . to the "lint" command in package.json
How Has This Been Tested?
Ran prettier --check . and prettier --write . (to apply the styling) on the full repository.
Breaking Changes
None, it's a devDependency.
Types of changes
Checklist
Additional context
As a further step, if Prettier gets agreed on and merged, a few improvements could be done on this initiative:
Maintainers please review the content of
.prettierrc.jsonso any desired changes can be applied there andprettier --write .can be ran again.