Skip to content

Fix serial-mode regression in pickle cache file manipulation tests#357

Merged
shaypal5 merged 3 commits intotesting-improvementsfrom
copilot/sub-pr-349-again
Mar 1, 2026
Merged

Fix serial-mode regression in pickle cache file manipulation tests#357
shaypal5 merged 3 commits intotesting-improvementsfrom
copilot/sub-pr-349-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 28, 2026

  • Identify the regression: isolated_cache_directory fixture patches _global_params.cache_dir for all pickle/maxage tests even in serial mode, breaking tests that use module-level hardcoded paths
  • Fix: only apply cache isolation when running in parallel mode (xdist), not in serial mode
  • Apply ruff format to fix pre-commit.ci formatting error

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix pre-commit CI errors in testing process Fix serial-mode regression in pickle cache file manipulation tests Feb 28, 2026
@shaypal5 shaypal5 marked this pull request as ready for review March 1, 2026 08:49
@shaypal5 shaypal5 self-requested a review as a code owner March 1, 2026 08:49
@shaypal5
Copy link
Member

shaypal5 commented Mar 1, 2026

@copilot fix pre-commit.ci errors:

fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
check json...........................................(no files to check)Skipped
check yaml...............................................................Passed
check toml...............................................................Passed
check docstring is first.................................................Passed
check that executables have shebangs.....................................Passed
check for case conflicts.................................................Passed
check for added large files..............................................Passed
detect private key.......................................................Passed
typos....................................................................Passed
docformatter.............................................................Passed
mdformat.................................................................Passed
prettier.................................................................Passed
Black by Ruff............................................................Failed
- hook id: ruff-format
- files were modified by this hook

warning: `incorrect-blank-line-before-class` (D203) and `no-blank-line-before-class` (D211) are incompatible. Ignoring `incorrect-blank-line-before-class`.
warning: `multi-line-summary-first-line` (D212) and `multi-line-summary-second-line` (D213) are incompatible. Ignoring `multi-line-summary-second-line`.
1 file reformatted, 64 files left unchanged

Ruff check...............................................................Passed
mypy.....................................................................Passed
pyproject-fmt............................................................Passed
Validate pyproject.toml..................................................Passed

Copy link
Member

@shaypal5 shaypal5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work identifying the problem and applying a focused fix.

Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 1, 2026

@copilot fix pre-commit.ci errors:

fix end of files.........................................................Passed

...

Fixed in commit 12ac8e6 — applied ruff format to collapse the multi-line if condition that pre-commit reformatted.

@shaypal5 shaypal5 merged commit 35f5190 into testing-improvements Mar 1, 2026
1 check passed
@shaypal5 shaypal5 deleted the copilot/sub-pr-349-again branch March 1, 2026 09:04
shaypal5 added a commit that referenced this pull request Mar 1, 2026
)

* Initial plan

* Fix regression: only apply cache isolation in parallel (xdist) mode

Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com>

* Apply ruff format to conftest.py to fix pre-commit.ci formatting error

Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants