Fix serial-mode regression in pickle cache file manipulation tests#357
Merged
shaypal5 merged 3 commits intotesting-improvementsfrom Mar 1, 2026
Merged
Fix serial-mode regression in pickle cache file manipulation tests#357shaypal5 merged 3 commits intotesting-improvementsfrom
shaypal5 merged 3 commits intotesting-improvementsfrom
Conversation
Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix pre-commit CI errors in testing process
Fix serial-mode regression in pickle cache file manipulation tests
Feb 28, 2026
Member
|
@copilot fix pre-commit.ci errors: |
shaypal5
approved these changes
Mar 1, 2026
Member
shaypal5
left a comment
There was a problem hiding this comment.
Excellent work identifying the problem and applying a focused fix.
Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com>
Contributor
Author
... Fixed in commit |
shaypal5
added a commit
that referenced
this pull request
Mar 1, 2026
) * Initial plan * Fix regression: only apply cache isolation in parallel (xdist) mode Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com> * Apply ruff format to conftest.py to fix pre-commit.ci formatting error Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: shaypal5 <917954+shaypal5@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isolated_cache_directoryfixture patches_global_params.cache_dirfor all pickle/maxage tests even in serial mode, breaking tests that use module-level hardcoded paths✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.