Skip to content

Fix serial-mode regression in pickle cache file manipulation tests #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaypal5 merged 3 commits into from
Mar 1, 2026
Merged

Fix serial-mode regression in pickle cache file manipulation tests #357

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
065808c
Initial plan
Copilot Feb 28, 2026
0188eba
Fix regression: only apply cache isolation in parallel (xdist) mode
Copilot Feb 28, 2026
12ac8e6
Apply ruff format to conftest.py to fix pre-commit.ci formatting error
Copilot Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,12 @@ def isolated_cache_directory(tmp_path, monkeypatch, request, worker_id):
This is especially important for pickle and maxage tests when running in parallel. Each pytest-xdist worker gets its
own cache directory to avoid conflicts.

Only applies when running in parallel mode (pytest-xdist), to avoid breaking tests that use module-level path
constants computed from the default cache directory at import time.

"""
if "pickle" in request.node.keywords or "maxage" in request.node.keywords:
# Create a unique cache directory for this test
cache_dir = tmp_path / "cachier_cache" if worker_id == "master" else tmp_path / f"cachier_cache_{worker_id}"
if worker_id != "master" and ("pickle" in request.node.keywords or "maxage" in request.node.keywords):
cache_dir = tmp_path / f"cachier_cache_{worker_id}"

cache_dir.mkdir(exist_ok=True, parents=True)

Expand Down