Skip to content

Conversation

@MartinPavella
Copy link
Collaborator

@MartinPavella MartinPavella commented Jan 30, 2026

Summary

Originally, the NXP backend used the NodeFormat enum to mark data formats (memory layouts) of ExecuTorch nodes, and the TensorFormat enum was used to mark the formats for Neutron IR tensors. However, these two classes fundamentally represent the same thing, and there is no need to keep them separated. Additionally, sometimes it was confusing as for which class to use which could result (and has resulted) in bugs.

This PR unifies these 2 enums into 1.

Test plan

N/A

cc @robert-kalmar @JakeStevens @digantdesai

@MartinPavella MartinPavella added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Jan 30, 2026
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 30, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17066

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures

As of commit d40397e with merge base 0b644f0 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 30, 2026
@MartinPavella
Copy link
Collaborator Author

This PR depends on #17002, so only the last commit is relevant.

@MartinPavella MartinPavella force-pushed the nxg01483/feature/EIEX-408-replace-tensorformat-with-nodeformat branch from 769ae19 to d40397e Compare February 5, 2026 13:09
@MartinPavella
Copy link
Collaborator Author

The failing checks seem unrelated, and the internal build passed. Merging.

@MartinPavella MartinPavella merged commit 4647342 into pytorch:main Feb 6, 2026
140 of 149 checks passed
@MartinPavella MartinPavella deleted the nxg01483/feature/EIEX-408-replace-tensorformat-with-nodeformat branch February 6, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants